[GitHub] [incubator-pinot] abachuk commented on a change in pull request #6210: [TE] frontend - abachuk/alert-details-ui-tweaks - formatting alert header

[GitBox]

abachuk commented on a change in pull request #6210:
URL: https://github.com/apache/incubator-pinot/pull/6210#discussion_r514405365



##########
File path: 
thirdeye/thirdeye-frontend/app/pods/components/self-serve-alert-yaml-details/template.hbs
##########
@@ -1,22 +1,24 @@
 <div class="te-search-results__header">
   <div class="te-search-results__title-group">
     <div class="te-search-results__title">
-      <span 
title={{alertData.detectionName}}>{{alertData.detectionName}}</span>
+      <h3 class="te-search-results__title-name" 
title={{alertData.detectionName}}>{{alertData.detectionName}}</h3>

Review comment:
       the class name doesn't hint the truncated text (there are no handlers), 
instead, the browser is using the title tag to display native tooltip on hover 
regardless if the text is truncated or not)
   
![truncated-title](https://user-images.githubusercontent.com/991587/97604454-e4184b00-19e3-11eb-858a-e9611d5e1572.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org