zhangloo333 commented on a change in pull request #6210:
URL: https://github.com/apache/incubator-pinot/pull/6210#discussion_r513904629
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/self-serve-alert-yaml-details/template.hbs
##########
@@ -1,103 +1,79 @@
-<div class="te-search-results__header">
- <div class="te-search-results__title-group">
+<div class="te-search-results__header row">
+ <div class=" te-search-results__title-group col-md-10 col-xs-9">
Review comment:
The indent issue before `te-search-results`
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/self-serve-alert-yaml-details/template.hbs
##########
@@ -1,22 +1,24 @@
<div class="te-search-results__header">
<div class="te-search-results__title-group">
<div class="te-search-results__title">
- <span
title={{alertData.detectionName}}>{{alertData.detectionName}}</span>
+ <h3 class="te-search-results__title-name"
title={{alertData.detectionName}}>{{alertData.detectionName}}</h3>
Review comment:
it's weird to see the title attribute in `h` tag. If we want to support
the screenreader, we may set a rule to add all title attribute for h tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
