deemoliu commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503541176
##########
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##########
@@ -80,6 +80,18 @@ public void testFieldSpec() {
Assert.assertEquals(fieldSpec1.hashCode(), fieldSpec2.hashCode());
Assert.assertEquals(fieldSpec1.getDefaultNullValue(), "false");
+ // Single-value boolean type dimension field with max length and default
null value.
+ fieldSpec1 = new DimensionFieldSpec();
+ fieldSpec1.setName("svDimension");
+ fieldSpec1.setDataType(BOOLEAN);
+ fieldSpec1.setDefaultNullValue(false);
+ fieldSpec1.setMaxLength(20000);
Review comment:
@chenboat @Jackie-Jiang thanks for the code review. I added precondition
in Schema.java for dimension columns. Regarding metrics column, does METRIC
column support String column?
I think it should be supported according to
https://docs.pinot.apache.org/configuration-reference/schema#metricfieldspecs
However in the schema.java it weren't been supported.
https://github.com/apache/incubator-pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java#L447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
