Jackie-Jiang commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r500672904
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -508,13 +517,22 @@ public SchemaBuilder addMultiValueDimension(String
dimensionName, DataType dataT
}
/**
- * Add single value dimensionFieldSpec with defaultNullValue
+ * Add multi value dimensionFieldSpec with defaultNullValue
*/
public SchemaBuilder addMultiValueDimension(String dimensionName, DataType
dataType, Object defaultNullValue) {
_schema.addField(new DimensionFieldSpec(dimensionName, dataType, false,
defaultNullValue));
return this;
}
+ /**
+ * Add multi value dimensionFieldSpec with maxLength and a defaultNullValue
+ */
+ public SchemaBuilder addMultiValueDimension(String dimensionName, DataType
dataType, int maxLength,
+ Object defaultNullValue) {
Review comment:
Reformat this
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -499,6 +499,15 @@ public SchemaBuilder addSingleValueDimension(String
dimensionName, DataType data
return this;
}
+ /**
+ * Add single value dimensionFieldSpec with maxLength and a
defaultNullValue
+ */
+ public SchemaBuilder addSingleValueDimension(String dimensionName,
DataType dataType, int maxLength,
+ Object defaultNullValue) {
Review comment:
Please reformat this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
