jackjlli commented on a change in pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r495619489
##########
File path:
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordExtractor.java
##########
@@ -45,18 +45,32 @@ public void init(Set<String> fields, @Nullable
RecordExtractorConfig recordExtra
@Override
public GenericRow extract(Map<String, Object> from, GenericRow to) {
if (_extractAll) {
- from.forEach((fieldName, value) -> to.putValue(fieldName,
JSONRecordExtractorUtils.convertValue(value)));
+ from.forEach((fieldName, value) -> to.putValue(fieldName,
convert(value)));
Review comment:
We had an internal meeting to discuss about the performance between
functional and procedural method a year ago.
Here's a doc on the performance of using functional method:
https://www.beyondjava.net/performance-java-8-lambdas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
