jackjlli commented on a change in pull request #6046:
URL: https://github.com/apache/incubator-pinot/pull/6046#discussion_r494744256
##########
File path:
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordExtractor.java
##########
@@ -45,18 +45,32 @@ public void init(Set<String> fields, @Nullable
RecordExtractorConfig recordExtra
@Override
public GenericRow extract(Map<String, Object> from, GenericRow to) {
if (_extractAll) {
- from.forEach((fieldName, value) -> to.putValue(fieldName,
JSONRecordExtractorUtils.convertValue(value)));
+ from.forEach((fieldName, value) -> to.putValue(fieldName,
convert(value)));
Review comment:
It'd be good to avoid using the non-functional way for performance
concern. Please refer to the way that `AvroRecordExtractor` uses. Same to the
other Extractors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
