suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486691580
##########
File path: thirdeye/pom.xml
##########
@@ -22,17 +22,18 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.pinot.thirdeye</groupId>
<artifactId>thirdeye</artifactId>
- <version>${revision}${sha1}</version>
Review comment:
I'll restore this. This has nothing to do with the current refactor.
But it seems like the build worked fine. As such haven't really found
versions to be used in TE. Also, the docker images uses its own versioning.
I made these changes initially just to make IntelliJ happy. There seems to
be a bug when using properties in parent section.
https://youtrack.jetbrains.com/issue/IDEA-179451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
