suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486692447
##########
File path: thirdeye/pom.xml
##########
@@ -543,6 +550,17 @@
<artifactId>log4j-slf4j-impl</artifactId>
<version>${log4j2.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>${commons-lang3.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-math</artifactId>
+ <version>2.1</version>
+ </dependency>
Review comment:
It is defined in this manner even in pinot. Didn't want to change the
existing convention. As such I find maven to be extremely verbose. But I do
agree and want to simplify the dependencies. I'm already working on that in a
separate branch. But I'm keeping this unchanges in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
