npawar commented on a change in pull request #5902:
URL: https://github.com/apache/incubator-pinot/pull/5902#discussion_r474110531
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -399,6 +400,28 @@ public synchronized PinotResourceManagerResponse
updateInstance(String instanceI
}
}
+ /**
+ * Updates the tags of the specified instance ID
+ */
+ public synchronized PinotResourceManagerResponse updateInstanceTags(String
instanceIdToUpdate, String tags) {
+ InstanceConfig instanceConfig = getHelixInstanceConfig(instanceIdToUpdate);
Review comment:
what kind of race conditions are you thinking about? All of the methods
which update this config are synchronized methods.
Are you thinking about race conditions across controllers? (we haven't
really handled that for any of our APIs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
