npawar commented on pull request #5902: URL: https://github.com/apache/incubator-pinot/pull/5902#issuecomment-677789176
> Doesnt this PR provide a way to update an instance record? Do we need a separate one to update tags? #4952 We're seeing many instances of users getting into erroneous states when using that API. Reasons being: 1. The template asks for too many things, which the users should not have to provide again. Asking for "host", "port", "instanceType" is redundant when the instance id like "Server_hostname_port" is already provided as PathParam. 2. Breaking up the "Server_hostname_port" correctly and setting the right parts in host, port is confusing users, and leading to irrecoverable error states. (e.g. someone put "Server_hostname_port" in host, someone put just "Server_hostname", whereas we need only "hostname". 3. There is inconsistency between the output of the GET API and the expected input of PUT/POST API. As a result, if someone takes the output of GET and uses it to update/add, again error state. I don't know how or when that inconsistency happened, but now due to backward incompatibility reasons, we cannot change either API. We can certainly deprecate the old APIs and introduce new APIs (as v2) to make it all consistent. But that would only solve 3. For a user who's just trying to update tags, having a simple API would help a lot. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
