cyrilou242 opened a new pull request #5868: URL: https://github.com/apache/incubator-pinot/pull/5868
## Description Added support of BigQuery as a datasource for ThirdEye. I followed https://thirdeye.readthedocs.io/en/latest/contribute_datasource.html. Design points: - The JDBC driver for BigQuery has to be downloaded and put into the maven project. Also, the driver requires specific version for some dependencies. A normal build is unchanged: `mvn install -DskipTests` and a build with bigquery is `mvn install -DskipTests -P bigquery` Also, I've added the same principle for `install.sh`: `./install.sh` has the same behavior as before, `./install.sh bigquery` downloads and install the driver, and compile with the bigquery profile. The install.sh loop can look a bit complex/over-engineered, but I am anticipating the fact that we will have other databases that require more ops or other profiles for specific dependencies. We already have another case for using CloudSQL on GCP, but it's not the purpose of this MR. To give you an idea, the result is `./install.sh bigquery cloudsql`. I am not a Java dev so I had no idea how to do this properly. Let me know if I you're thinking of a better way to do this. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) No Does this PR fix a zero-downtime upgrade introduced earlier? No Does this PR otherwise need attention when creating release notes? Things to consider: No ## Release Notes Added support for BigQuery as a datasource in ThirdEye. ## Documentation I've added a documentation page here `thirdeye/docs/bigquery.rst`, but I did not find how to build the doc so I'm not 100% sure it builds correctly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
