daniellavoie commented on pull request #5669: URL: https://github.com/apache/incubator-pinot/pull/5669#issuecomment-656182611
@kishoreg I've added full test coverage on PinotConfiguration. The base constructor that accepts Commons Configuration was broken and has been fixed. I also identified a missing register operation on the Hadoop JobRunner. If possible, can you rebase this PR branch to https://github.com/daniellavoie/incubator-pinot/tree/pinot-fs-bug-fix ? I can't push my modifications to branches in this repository. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
