kishoreg commented on a change in pull request #5669:
URL: https://github.com/apache/incubator-pinot/pull/5669#discussion_r451954329
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFSFactory.java
##########
@@ -60,19 +60,19 @@ public static void register(String scheme, String
fsClassName, PinotConfiguratio
}
}
- public static void init(PinotConfiguration fsConfig) {
+ public static void init(PinotConfiguration config) {
// Get schemes and their respective classes
- PinotConfiguration schemesConfiguration = fsConfig.subset(CLASS);
+ PinotConfiguration schemesConfiguration = config.subset(CLASS);
List<String> schemes = schemesConfiguration.getKeys();
if (!schemes.isEmpty()) {
LOGGER.info("Did not find any fs classes in the configuration");
}
for(String scheme : schemes){
- String fsClassName = (String) schemesConfiguration.getProperty(scheme);
-
- LOGGER.info("Got scheme {}, classname {}, starting to initialize",
scheme, fsClassName);
- register(scheme, fsClassName, schemesConfiguration.subset(scheme));
+ String fsClassName = schemesConfiguration.getProperty(scheme);
+ PinotConfiguration fsConfiguration = config.subset(scheme);
+ LOGGER.info("Got scheme {}, initializing class {} with config : {} ",
scheme, fsClassName, fsConfiguration.toMap());
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
