mayankshriv commented on pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-638597901
> @mayankshriv Did a rough performance benchmark running all the queries in the query file for 10 times (100K queries in total) in Hybrid, MultiNodesOffline and Realtime cluster integration test and the result is very close before and after this PR (both within the range of 23-24 seconds). > So the gain of this PR is mostly for simplicity and readability of the code as well as enhancement for certain code path (e.g. the problem addressed in #5328 won't happen again) Thank you @Jackie-Jiang for performing this benchmark, much appreciated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
