Jackie-Jiang commented on pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-638356820
> Changes to query execution engine should go through a performance benchmark. @mayankshriv Totally agree. But before the benchmark framework is ready, there is no way to test the performance thoroughly. I already tested the functionality with all the queries in the integration test, and conceptually this change will improve the performance because the it removes some redundant if checks and optimizes certain code paths. I also noticed that the tests are finished a little bit faster, but the difference is within error range. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
