chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606505
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockValIterator.java
##########
@@ -20,9 +20,23 @@
public interface BlockValIterator {
+ /**
+ * Returns {@code true} if there are more values in the iterator, {@code
false} otherwise.
+ */
boolean hasNext();
+ /**
+ * Returns the next document id to be read.
+ */
+ int getNextDocId();
+
+ /**
+ * Sets the next document id to the given document id.
Review comment:
what is the behavior if the input doc id does not exist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
