Jackie-Jiang commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r430789063
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/readerwriter/impl/FixedByteSingleColumnMultiValueReaderWriter.java
##########
@@ -277,42 +260,6 @@ public void setStringArray(int row, String[] stringArray) {
}
}
- @Override
Review comment:
No, I only removed the ones that does not apply to Pinot types (we don't
support MV BYTES).
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/writer/SingleColumnMultiValueWriter.java
##########
@@ -19,60 +19,14 @@
package org.apache.pinot.core.io.writer;
public interface SingleColumnMultiValueWriter extends DataFileWriter {
- /**
Review comment:
Same here. I only removed the ones that does not apply to Pinot data
types.
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockValIterator.java
##########
@@ -22,6 +22,8 @@
boolean hasNext();
+ int getNextDocId();
Review comment:
This iterator is not only iterator but supports `skipTo(docId)` and
`reset()`. It is easier to track the docId here comparing to tracking it on the
caller side. I'll add some javadoc to explain this
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java
##########
@@ -21,6 +21,4 @@
public interface BlockDocIdSet {
BlockDocIdIterator iterator();
Review comment:
Good point, will add javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
