jackjlli commented on a change in pull request #5282: URL: https://github.com/apache/incubator-pinot/pull/5282#discussion_r427497365
########## File path: .travis.yml ########## @@ -10,6 +10,7 @@ before_install: - jq --version - curl -sSL -o ~/bin/install-jdk.sh https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh && chmod +x ~/bin/install-jdk.sh - source ./.travis/.travis_set_deploy_build_opts.sh + - npm install -g npm-login-noninteractive Review comment: I think it'd be good to put this line in `.travis_set_deploy_build_opts.sh` if not all builds need this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
