jackjlli commented on a change in pull request #5282:
URL: https://github.com/apache/incubator-pinot/pull/5282#discussion_r413170563
##########
File path: thirdeye/thirdeye-pinot/pom.xml
##########
@@ -448,6 +448,19 @@
</properties>
</configuration>
</plugin>
+ <plugin>
Review comment:
You may skip this plugin since `mvn deploy` is directly used.
##########
File path: thirdeye/thirdeye-frontend/pom.xml
##########
@@ -3,13 +3,9 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";
xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
<modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.pinot.thirdeye</groupId>
- <artifactId>thirdeye</artifactId>
- <version>1.0-SNAPSHOT</version>
- </parent>
<groupId>org.apache.pinot.thirdeye</groupId>
<artifactId>thirdeye-frontend</artifactId>
+ <version>1.0-SNAPSHOT</version>
Review comment:
You may wanna use revision and sha1 to present version.
##########
File path: thirdeye/pom.xml
##########
@@ -22,16 +22,16 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.pinot.thirdeye</groupId>
<artifactId>thirdeye</artifactId>
- <version>1.0-SNAPSHOT</version>
+ <version>${revision}${sha1}</version>
<packaging>pom</packaging>
<name>thirdeye</name>
<modules>
- <module>thirdeye-frontend</module>
<module>thirdeye-pinot</module>
</modules>
<properties>
+ <revision>1.0.0</revision>
Review comment:
The property of sha1 is missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
