mcvsubbu commented on a change in pull request #5399:
URL: https://github.com/apache/incubator-pinot/pull/5399#discussion_r427479912



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/V1Constants.java
##########
@@ -51,6 +51,10 @@
       public static final String TABLE_NAME = "segment.table.name";
       public static final String DIMENSIONS = "segment.dimension.column.names";
       public static final String METRICS = "segment.metric.column.names";
+      /**
+       * The primary time column for the table. This will match the 
timeColumnName defined in the tableConfig.
+       * In the Pinot schema, this column can be defined as either a 
TimeFieldSpec or DateTimeFieldSpec

Review comment:
       mention in the comment that TimeFieldSpec is deprecated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to