haibow commented on a change in pull request #5399:
URL: https://github.com/apache/incubator-pinot/pull/5399#discussion_r426114553
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/function/FunctionEvaluatorFactory.java
##########
@@ -59,7 +59,8 @@ public FunctionEvaluator getExpressionEvaluator(FieldSpec
fieldSpec) {
}
} else if (fieldSpec.getFieldType().equals(FieldSpec.FieldType.TIME)) {
- // for backward compatible handling of TIME field conversion
+ // Time conversions should be done using DateTimeFieldSpec and
treansformFunctions
Review comment:
nit: s/treansformFunctions/transformFunctions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
