npawar commented on a change in pull request #5378:
URL: https://github.com/apache/incubator-pinot/pull/5378#discussion_r426058077
##########
File path:
pinot-core/src/test/java/org/apache/pinot/realtime/converter/RealtimeSegmentConverterTest.java
##########
@@ -46,28 +46,11 @@ public void testNoVirtualColumnsInSchema() {
String segmentName = "segment1";
VirtualColumnProviderFactory.addBuiltInVirtualColumnsToSegmentSchema(schema,
segmentName);
Assert.assertEquals(schema.getColumnNames().size(), 5);
-
Assert.assertEquals(schema.getTimeFieldSpec().getIncomingGranularitySpec().getTimeType(),
TimeUnit.MILLISECONDS);
RealtimeSegmentConverter converter =
new RealtimeSegmentConverter(null, "", schema, "testTable",
tableConfig, segmentName, "col1");
Schema newSchema = converter.getUpdatedSchema(schema);
Assert.assertEquals(newSchema.getColumnNames().size(), 2);
-
Assert.assertEquals(newSchema.getTimeFieldSpec().getIncomingGranularitySpec().getTimeType(),
TimeUnit.DAYS);
- }
-
- @Test
- public void testNoTimeColumnsInSchema() {
- Schema schema = new Schema();
Review comment:
realtime table without time will never happen right?
Also after changing the getUpdatedSchema method, this test becomes irrelevant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
