npawar commented on a change in pull request #5378:
URL: https://github.com/apache/incubator-pinot/pull/5378#discussion_r426057601
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/RealtimeSegmentConverter.java
##########
@@ -156,20 +156,8 @@ public void build(@Nullable SegmentVersion segmentVersion,
ServerMetrics serverM
@VisibleForTesting
public Schema getUpdatedSchema(Schema original) {
Review comment:
I believe we don't need to change the schema because:
1) The RecordTransformer is a pass through
2) The RecordReader is just looping over physical column names so it only
has outgoing
We shouldn't need to remove incoming, because that implies that we need to
remove transform functions from all field specs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
