Vamsi-klu commented on PR #19027:
URL: https://github.com/apache/pinot/pull/19027#issuecomment-5052756020
@xiangfu0 Addressed the high-severity BC feedback from your review (see also
the inline thread).
**What changed**
- Default SQL DQL behavior no longer rejects unknown `SET` / `OPTION(...)`
keys; custom keys are preserved again for upgrade safety and
plugin/BrokerRequest option consumers.
- Opt-in strict validation:
- Query: `SET strictQueryOptions=true`
- Broker: `pinot.broker.query.sql.strictQueryOptions` (default `false`)
- Extension registry: `QueryOptionsUtils.registerSqlQueryOptionKey(...)` so
plugins can allowlist keys under strict mode without forking core.
- User-supplied `rlsFilters*` remains rejected on the SQL path.
- REST/JSON `queryOptions` and DML free-form paths stay permissive.
This keeps a path to the #7207 fail-fast UX without a hard cluster-wide
break on upgrade. Please take another look when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
