Vamsi-klu commented on PR #19027: URL: https://github.com/apache/pinot/pull/19027#issuecomment-5030174548
Ready for review. Rejects unknown SQL query options on the DQL SET / OPTION path (apache/pinot#7207). REST/JSON free-form queryOptions stay permissive for backward compatibility. DML free-form SET is unchanged. User-supplied rlsFilters keys are rejected on the SQL path (broker injects RLS after parse). Please take a look when you have a chance: - @Jackie-Jiang - @xiangfu0 Backward compatibility: - Breaking for SQL DQL that used arbitrary free-form SET/OPTION keys. - Non-breaking for REST/JSON queryOptions and broker-injected options. Happy to adjust allowlist or error messaging based on feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
