xiangfu0 commented on code in PR #18480:
URL: https://github.com/apache/pinot/pull/18480#discussion_r3337342711
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1835,13 +1842,13 @@ public RealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableConf
.setOffHeap(_isOffHeap)
.setMemoryManager(_memoryManager)
.setStatsHistory(realtimeTableDataManager.getStatsHistory())
- .setAggregateMetrics(indexingConfig.isAggregateMetrics())
-
.setIngestionAggregationConfigs(IngestionConfigUtils.getAggregationConfigs(tableConfig))
- .setDefaultNullHandlingEnabled(_defaultNullHandlingEnabled)
+
.setAggregateMetrics(consumingSegmentIndexingConfig.isAggregateMetrics())
Review Comment:
Fixed by keeping the synthetic `consuming` tier override limited to the
mutable segment index-loading/text-index view. `RealtimeSegmentDataManager` now
takes aggregate metrics, ingestion aggregation configs, default null handling,
and partition parameters from the persisted table config, so a consuming-only
override cannot change row shape or committed segment metadata. I also updated
unit coverage and reran the focused realtime integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
