xiangfu0 commented on code in PR #18480:
URL: https://github.com/apache/pinot/pull/18480#discussion_r3241254039
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1835,13 +1842,13 @@ public RealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableConf
.setOffHeap(_isOffHeap)
.setMemoryManager(_memoryManager)
.setStatsHistory(realtimeTableDataManager.getStatsHistory())
- .setAggregateMetrics(indexingConfig.isAggregateMetrics())
-
.setIngestionAggregationConfigs(IngestionConfigUtils.getAggregationConfigs(tableConfig))
- .setDefaultNullHandlingEnabled(_defaultNullHandlingEnabled)
+
.setAggregateMetrics(consumingSegmentIndexingConfig.isAggregateMetrics())
Review Comment:
This now treats `tierOverwrites.consuming.aggregateMetrics` as a
mutable-segment setting, but `aggregateMetrics` changes row semantics, not just
index layout. `MutableSegmentImpl` will collapse rows while the segment is
consuming, and `RealtimeSegmentConverter` then writes those already-collapsed
rows into the immutable segment even though the persisted table config still
has `aggregateMetrics=false`. A consuming-only override can therefore
permanently change query results after commit; this path should reject or
ignore non-index knobs like `aggregateMetrics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
