yashmayya commented on code in PR #17438:
URL: https://github.com/apache/pinot/pull/17438#discussion_r2670089351
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -317,6 +317,11 @@ public static class Instance {
// Setting the before serving queries to Integer.MAX_VALUE to effectively
disable throttling by default
public static final String
DEFAULT_MAX_SEGMENT_DOWNLOAD_PARALLELISM_BEFORE_SERVING_QUERIES =
String.valueOf(Integer.MAX_VALUE);
+
+ // SQL parsing
+ public static final String CONFIG_OF_SSE_LEGACY_LITERAL_UNESCAPING =
Review Comment:
This isn't just a broker config though, since it can be used in some server
side paths as well. From the PR description:
> Added `InstanceConfigProvider` singleton in `pinot-spi` for global access
to instance config (broker / server, can be extended to controller / minion)
from any module. Note that this pattern can be used in various scenarios in the
future but is particularly useful here because we need to access the
configuration from a static context that can be called from a broker path (Main
SQL query parsing, time series request handler, RLS filter rewriter) or a
server path (JSON index filter parsing, theta sketch agg function, time series
server side execution).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
