xiangfu0 commented on code in PR #17375:
URL: https://github.com/apache/pinot/pull/17375#discussion_r2664307276
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3562,6 +3562,38 @@ public List<String> getBrokerInstancesForTable(String
tableName, TableType table
}
public PinotResourceManagerResponse enableInstance(String instanceName) {
+ // If enabling a drained minion, restore to its previous tags
Review Comment:
wrap this restore minion tags logic into a method and put it in to the:
```private PinotResourceManagerResponse enableInstance(String instanceName,
boolean enableInstance, long timeOutMs)
```
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3562,6 +3562,38 @@ public List<String> getBrokerInstancesForTable(String
tableName, TableType table
}
public PinotResourceManagerResponse enableInstance(String instanceName) {
+ // If enabling a drained minion, restore to its previous tags
Review Comment:
wrap this restore minion tags logic into a method and put it in to the:
```
private PinotResourceManagerResponse enableInstance(String instanceName,
boolean enableInstance, long timeOutMs)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
