krishna-st commented on code in PR #17375: URL: https://github.com/apache/pinot/pull/17375#discussion_r2632386804
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java: ########## @@ -252,17 +253,20 @@ public SuccessResponse addInstance( @Authenticate(AccessType.UPDATE) @Produces(MediaType.APPLICATION_JSON) @Consumes(MediaType.TEXT_PLAIN) - @ApiOperation(value = "Enable/disable an instance", notes = "Enable/disable an instance") + @ApiOperation(value = "Enable/disable/drain an instance", notes = "Enable/disable/drain an instance. " + + "DRAIN state is only applicable to minion instances and retags them from minion_untagged to minion_drained, " Review Comment: In this scenario, yes, because ideally, if the minion is tagged with something else, then there are no tasks that are currently being assigned to it, unless the table config has `minionInstanceTag` present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
