xiangfu0 commented on code in PR #17450:
URL: https://github.com/apache/pinot/pull/17450#discussion_r2659553921
##########
pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts:
##########
@@ -227,28 +215,21 @@ const getInstanceData = (instances, liveInstanceArr) => {
// Then check health endpoints for alive instances
const healthCheckPromises = instanceRecords.map(async (record) => {
+
+ let status: InstanceStatusCell = {value: InstanceStatus.DEAD, tooltip:
'Instance is not running'};
Review Comment:
Is this an async api which we need a placeholder than it may change later on?
Or we will mark anything unknown/not returned on time as dead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
