jadami10 commented on code in PR #17450:
URL: https://github.com/apache/pinot/pull/17450#discussion_r2658386982
##########
pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts:
##########
@@ -227,28 +215,21 @@ const getInstanceData = (instances, liveInstanceArr) => {
// Then check health endpoints for alive instances
const healthCheckPromises = instanceRecords.map(async (record) => {
+
+ let status: InstanceStatusCell = {value: InstanceStatus.DEAD, tooltip:
'Instance is not running'};
+
if (!record.isAlive) {
- return { ...record, healthStatus: 'Dead' };
+ return { ...record, healthStatus: status };
}
- // Determine which port to use for health check
- // For brokers and servers, use adminPort if available, otherwise use
main port
- const healthPort = record.adminPort && record.adminPort > 0 ?
record.adminPort : record.port;
- const isHealthy = await checkInstanceHealth(record.hostName, healthPort);
Review Comment:
from the description, I'm removing this check because it queries the servers
directly from the browser. We don't have that access internally, and it's
likely not a good practice to allow servers to be queried directly from the
browsers.
For servers, we can infer health based on `shutdownInProgress`.
Brokers/controllers don't have that, but they also restart quickly and are
mostly stateless, so not having this check is less important for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
