Copilot commented on code in PR #17215:
URL: https://github.com/apache/pinot/pull/17215#discussion_r2652698155
##########
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java:
##########
@@ -113,6 +114,15 @@ public List<String> getInstances(int partitionId, int
replicaGroupId) {
.get(Integer.toString(partitionId) + PARTITION_REPLICA_GROUP_SEPARATOR
+ replicaGroupId);
}
+ /**
+ *
+ * @param partitionReplica
+ * @return
Review Comment:
Empty Javadoc comment with no description. The method should document what
it does, the parameter's purpose, and what it returns.
```suggestion
* Returns the list of instances assigned to the given partition-replica
key.
*
* @param partitionReplica Partition-replica identifier in the form {@code
"<partitionId>_<replicaGroupId>"},
* for example {@code "0_0"}.
* @return List of instances associated with the specified
partition-replica key, or {@code null} if none exist.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
