yashmayya commented on code in PR #17215:
URL: https://github.com/apache/pinot/pull/17215#discussion_r2529071407
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -245,6 +247,30 @@ static SortedMap<String, String>
convertToSortedMap(Map<String, String> map) {
}
}
+ protected Map<String, Integer> serverToReplicaGroupMap(IdealState
idealState) {
+ Map<String, Integer> serverToReplicaGroupMap = new HashMap<>();
+
+ for (Map.Entry<String, List<String>> listFields :
idealState.getRecord().getListFields().entrySet()) {
+ String key = listFields.getKey();
+ // key looks like "INSTANCE_PARTITIONS__myTable_CONSUMING__0_0"
Review Comment:
Maybe we should name it something slightly different (like routing instance
partitions) to make sure that there's never confusion about which one should be
used for segment assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
