krishan1390 commented on code in PR #17424:
URL: https://github.com/apache/pinot/pull/17424#discussion_r2650207490
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -247,4 +250,12 @@ public void onBecomeDroppedFromError(Message message,
NotificationContext contex
}
}
}
+
+ @Override
+ public ExecutorService getExecutorService(String resourceName, String
fromState, String toState) {
Review Comment:
yes we need to configure it appropriatley. Overall, I think we need 3
behaviours
1. default - use existing helix thread pool executor
2. thread pool based on state transition type (already added in the PR). I
agree this is a more manageable conf
3. thread pool based on resource name. This will be required in extreme
cases where tables are stepping on each other. Having this capability will
enable configuring it when required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
