J-HowHuang commented on code in PR #17424:
URL: https://github.com/apache/pinot/pull/17424#discussion_r2648536929
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -247,4 +250,12 @@ public void onBecomeDroppedFromError(Message message,
NotificationContext contex
}
}
}
+
+ @Override
+ public ExecutorService getExecutorService(String resourceName, String
fromState, String toState) {
Review Comment:
What I'm unsure is that this allows the limit of ongoing transitions to go
from 40 to something way bigger. Especially in the case during server start, a
cluster with 100 tables would then results in 4000 state transitions
concurrently. If we have all expensive operations throttled, then having thread
pool per table might be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
