ankitsultana commented on code in PR #17278:
URL: https://github.com/apache/pinot/pull/17278#discussion_r2628787148
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/TimeSeriesExchangeReceiveOperator.java:
##########
@@ -218,6 +244,10 @@ private TimeSeriesBlock getNextBlockNoAggregation()
mergeStats(aggregatedStats, blockToMerge.getMetadata());
}
Preconditions.checkNotNull(timeBuckets, "Time buckets is null in exchange
receive operator");
- return new TimeSeriesBlock(timeBuckets, timeSeriesMap, aggregatedStats);
+ TimeSeriesBlock resultBlock = new TimeSeriesBlock(timeBuckets,
timeSeriesMap, aggregatedStats);
+ if (timeoutException != null) {
+ resultBlock.addToExceptions(timeoutException);
Review Comment:
@shauryachats : in a future PR let's also update exception handling in the
open source timeseries plugin.
cc: @raghavyadav01 : after this PR, if you are combining time series blocks
in operations such as divideSeries, you should also copy over exceptions from
any of the blocks and pass them to the resulting block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
