ankitsultana commented on code in PR #17278:
URL: https://github.com/apache/pinot/pull/17278#discussion_r2621602185
##########
pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/TimeSeriesBlock.java:
##########
@@ -41,7 +43,11 @@ public class TimeSeriesBlock {
/**
* Holds optional metadata about the block (e.g., statistics).
*/
- private Map<String, String> _metadata;
+ private final Map<String, String> _metadata;
+ /**
+ * Holds exceptions encountered during processing of the block.
+ */
+ private final List<QueryException> _exceptions;
Review Comment:
This behavior differs from the single stage engine. SSE will collect all
exceptions in a server and send them along with any partial data to the broker.
The broker can then take a call about whether to return the errors as a warning
or whether to fail the query immediately.
Ideally we should follow the same convention and send the errors in a
serialized form to the broker and let the broker choose how it wants to handle
it in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
