MeihanLi commented on code in PR #17177:
URL: https://github.com/apache/pinot/pull/17177#discussion_r2625637201
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -311,11 +331,11 @@ protected BrokerResponse handleRequestThrowing(long
requestId, String query, Sql
QueryExecutionContext executionContext =
new QueryExecutionContext(QueryExecutionContext.QueryType.MSE,
requestId, cid, workloadName, startTimeMs,
- activeDeadlineMs, passiveDeadlineMs, _brokerId, _brokerId);
+ activeDeadlineMs, passiveDeadlineMs, _brokerId, _brokerId,
queryHash);
QueryThreadContext.MseWorkerInfo mseWorkerInfo = new
QueryThreadContext.MseWorkerInfo(0, 0);
try (QueryThreadContext ignore = QueryThreadContext.open(executionContext,
mseWorkerInfo, _threadAccountant);
Review Comment:
Removed the duplicate MDC registration line 313. QueryThreadContext already
handles the MDC registration in its constructor and cleanup in its close()
method.
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -340,7 +359,8 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
// TODO: Revisit whether we should set deadline here
QueryExecutionContext executionContext =
new QueryExecutionContext(QueryExecutionContext.QueryType.SSE,
requestId, cid, workloadName,
- requestContext.getRequestArrivalTimeMillis(), Long.MAX_VALUE,
Long.MAX_VALUE, _brokerId, _brokerId);
+ requestContext.getRequestArrivalTimeMillis(), Long.MAX_VALUE,
Long.MAX_VALUE, _brokerId, _brokerId,
+ queryHash);
try (QueryThreadContext ignore = QueryThreadContext.open(executionContext,
_threadAccountant)) {
Review Comment:
same here. Removed the duplicate MDC registration line 344.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
