xiangfu0 commented on code in PR #17356:
URL: https://github.com/apache/pinot/pull/17356#discussion_r2613587973
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java:
##########
@@ -133,7 +133,9 @@ protected List<SegmentConversionResult>
convert(PinotTaskConfig pinotTaskConfig,
}
// create new UploadedRealtimeSegment
-
segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments);
+ // set the creation time to maxCreationTimeOfMergingSegments + 1 to ensure
that the all records in merging
Review Comment:
```suggestion
// set the creation time to maxCreationTimeOfMergingSegments + 1 to
ensure that all records in merging
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
