Copilot commented on code in PR #17356:
URL: https://github.com/apache/pinot/pull/17356#discussion_r2613574837
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java:
##########
@@ -133,7 +133,9 @@ protected List<SegmentConversionResult>
convert(PinotTaskConfig pinotTaskConfig,
}
// create new UploadedRealtimeSegment
-
segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments);
+ //Setting the creation time to maxCreationTimeOfMergingSegments + 1 to
ensure that the all records in merging
+ // segments are replaced with new merged segment
+
segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments+1);
Review Comment:
Add whitespace around the '+' operator for better readability. The
expression should be written as `maxCreationTimeOfMergingSegments + 1`.
```suggestion
segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments
+ 1);
```
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java:
##########
@@ -133,7 +133,9 @@ protected List<SegmentConversionResult>
convert(PinotTaskConfig pinotTaskConfig,
}
// create new UploadedRealtimeSegment
-
segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments);
+ //Setting the creation time to maxCreationTimeOfMergingSegments + 1 to
ensure that the all records in merging
Review Comment:
Corrected 'that the all' to 'that all'.
```suggestion
//Setting the creation time to maxCreationTimeOfMergingSegments + 1 to
ensure that all records in merging
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
