Jackie-Jiang commented on code in PR #17284:
URL: https://github.com/apache/pinot/pull/17284#discussion_r2608756846
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountULLAggregationFunction.java:
##########
@@ -338,12 +341,18 @@ public UltraLogLog
extractGroupByResult(GroupByResultHolder groupByResultHolder,
}
@Override
- public UltraLogLog merge(UltraLogLog intermediateResult1, UltraLogLog
intermediateResult2) {
- int largerP = Math.max(intermediateResult1.getP(),
intermediateResult2.getP());
- UltraLogLog merged = UltraLogLog.create(largerP);
- merged.add(intermediateResult1);
- merged.add(intermediateResult2);
- return merged;
+ public UltraLogLog merge(@Nullable UltraLogLog intermediateResult1,
@Nullable UltraLogLog intermediateResult2) {
Review Comment:
(minor) Annotate return as `@Nullable`, same for other classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
