xiangfu0 commented on code in PR #17284:
URL: https://github.com/apache/pinot/pull/17284#discussion_r2570091775
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountULLAggregationFunction.java:
##########
@@ -309,7 +309,7 @@ public void aggregateGroupByMV(int length, int[][]
groupKeysArray, GroupByResult
public UltraLogLog extractAggregationResult(AggregationResultHolder
aggregationResultHolder) {
Object result = aggregationResultHolder.getResult();
if (result == null) {
- return UltraLogLog.create(_p);
+ return null;
Review Comment:
default ULL object will cause merge failure if p is not the same as what the
data has.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
