krishan1390 commented on code in PR #17191:
URL: https://github.com/apache/pinot/pull/17191#discussion_r2556868352
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/DefaultValueColumnReader.java:
##########
@@ -300,6 +301,13 @@ public boolean isNull(int docId) {
return _defaultValue == null;
}
+ @Override
+ public Object getValue(int docId)
Review Comment:
Added this as its required when we want to do random access on a column but
read as an Object (some Pinot interfaces like Partitioner don't have primitive
APIs. In such cases, we can read as Object and avoid additional code to read
based on data type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
