krishan1390 opened a new pull request, #17191:
URL: https://github.com/apache/pinot/pull/17191

   Refactor SegmentIndexCreationDriverImpl and SegmentColumnarIndexCreator to 
seperate reusable functionality
   
   1. Move logic of building the final segment (which involves segment name 
generation, building post ingestion indexes, converting format, updating CRC, 
etc) after data has been indexed from SegmentIndexCreationDriverImpl to 
SegmentCreationFinalizer
   2. Move logic of initializing various indexes and their metadata away from 
SegmentColumnarIndexCreator to AbstractSegmentCreator
   
   This enables us to have different mechanisms of ingesting and indexing data 
(independent of current SegmentProcessorFramework / 
SegmentIndexCreationDriverImpl / SegmentColumnarIndexCreator) and reuse 
existing functionality of index management and final segment building. 
   
   Other changes
   1. Create ColumnIndexCreators to hold _dictionaryCreator, indexCreators, 
nullVectorCreator etc. This enables us to add new creators easily and also to 
share all index creators of a column easily


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to