Jackie-Jiang commented on code in PR #17198:
URL: https://github.com/apache/pinot/pull/17198#discussion_r2543794369
##########
pinot-spi/src/main/java/org/apache/pinot/spi/executor/HardLimitExecutor.java:
##########
@@ -38,18 +38,33 @@ public class HardLimitExecutor extends
DecoratorExecutorService {
private final AtomicInteger _running;
private final int _max;
private final QueryThreadExceedStrategy _exceedStrategy;
+ private final Runnable _taskRejectionCounter;
- public HardLimitExecutor(int max, ExecutorService executorService,
QueryThreadExceedStrategy exceedStrategy) {
+ public HardLimitExecutor(int max, ExecutorService executorService,
QueryThreadExceedStrategy exceedStrategy,
Review Comment:
Not introduced in this PR, but this class doesn't really belong to
`pinot-spi`. I think you can move this class into `pinot-query-runtime` and
directly update the server metric within the class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
