priyen-stripe commented on code in PR #17198:
URL: https://github.com/apache/pinot/pull/17198#discussion_r2519791802
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -153,7 +153,11 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
// ThrottleOnCriticalHeapUsageExecutor metrics
THROTTLE_EXECUTOR_QUEUE_SIZE("count", true,
- "Current number of tasks in the throttle executor queue");
+ "Current number of tasks in the throttle executor queue"),
+
+ // Multi-stage executor thread usage metrics
+ MSE_THREAD_USAGE_MAX("threads", true, "Maximum allowed threads for
multi-stage executor"),
Review Comment:
we would like to keep this as without it you can't compute the % of limit
used. Ideally we can setup alerts/detectors when users are approaching their
limits and action it before they notice. If this metric is not available, we
wont be able to
do you antipciate processing overhead even if its just set once during
constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
