ankitsultana commented on code in PR #17117:
URL: https://github.com/apache/pinot/pull/17117#discussion_r2482109902
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/strategy/TimeRetentionStrategy.java:
##########
@@ -39,6 +39,12 @@ public TimeRetentionStrategy(TimeUnit timeUnit, long
timeValue) {
@Override
public boolean isPurgeable(String tableNameWithType, SegmentZKMetadata
segmentZKMetadata) {
+
+ // Skip retention check for incomplete segments (IN_PROGRESS or COMMITTING
status) as they have end time of -1
+ if (!segmentZKMetadata.getStatus().isCompleted()) {
Review Comment:
Hmm what about offline tables? I don't think they have this status field and
it might be null for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
