ankitsultana commented on code in PR #17117:
URL: https://github.com/apache/pinot/pull/17117#discussion_r2480165863
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/strategy/TimeRetentionStrategy.java:
##########
@@ -39,6 +40,12 @@ public TimeRetentionStrategy(TimeUnit timeUnit, long
timeValue) {
@Override
public boolean isPurgeable(String tableNameWithType, SegmentZKMetadata
segmentZKMetadata) {
+
+ // Skip retention check for consuming segments (IN_PROGRESS status) as
they have end time of -1
+ if (segmentZKMetadata.getStatus() == Status.IN_PROGRESS) {
Review Comment:
We also need to handle COMMITTING status? It was introduced by pauseless
ingestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
