yashmayya commented on code in PR #17091:
URL: https://github.com/apache/pinot/pull/17091#discussion_r2468066149
##########
config/checkstyle.xml:
##########
@@ -174,6 +174,10 @@
value="javax.annotation.Nonnull,
javax.validation.constraints.NotNull"/>
</module>
+ <!-- Disallow importing com.google.common.collect.ImmutableMap (use
java.util.Map instead) -->
+ <module name="IllegalImport">
+ <property name="illegalClasses"
value="com.google.common.collect.ImmutableMap"/>
+ </module>
Review Comment:
Why is this rule needed - did we find any issues in Guava's immutable map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
